Convert provider picker to a two-column popup#389
Closed
jasnsy wants to merge 6 commits intoOpenKnots:mainfrom
Closed
Convert provider picker to a two-column popup#389jasnsy wants to merge 6 commits intoOpenKnots:mainfrom
jasnsy wants to merge 6 commits intoOpenKnots:mainfrom
Conversation
|
@jasnsy is attempting to deploy a commit to the 0xBuns Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the chat provider/model selection UX to a two-column popup while also introducing a new Copilot provider end-to-end (contracts, web settings/picker, and server runtime integration).
Changes:
- Replaces the stacked provider/model menu with a two-column popup (providers left, models right) and updates browser tests for the new interaction.
- Adds Copilot as a first-class provider across contracts, shared model utilities, web settings/custom models, and server health/adapter registry.
- Adds a single-write
setProviderAndModelpathway to avoid intermediate draft states when switching provider+model.
Reviewed changes
Copilot reviewed 29 out of 30 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/shared/src/model.ts | Adds Copilot reasoning effort + model option normalization and Copilot-aware slug/provider inference. |
| packages/contracts/src/providerRuntime.ts | Adds Copilot runtime raw event source literal. |
| packages/contracts/src/orchestration.ts | Extends ProviderKind and start options to include Copilot. |
| packages/contracts/src/model.ts | Adds Copilot model options, defaults, aliases, and reasoning effort options. |
| bun.lock | Locks new @github/copilot-sdk (and transitive) dependency. |
| apps/web/src/store.ts | Allows openclaw/copilot provider names to flow through legacy mapping + inference. |
| apps/web/src/session-logic.ts | Adds Copilot to provider option list. |
| apps/web/src/routes/_chat.settings.tsx | Adds Copilot install/settings + includes Copilot/OpenClaw in custom model counts/resets. |
| apps/web/src/composerDraftStore.ts | Adds setProviderAndModel and expands provider normalization to include Copilot/OpenClaw. |
| apps/web/src/composerDraftStore.test.ts | Adds test coverage for setProviderAndModel. |
| apps/web/src/components/sme/SmeConversationDialog.tsx | Includes Copilot custom models in SME config payload. |
| apps/web/src/components/sme/smeConversationConfig.ts | Adds Copilot label + auth method behavior for SME UI. |
| apps/web/src/components/home/home-utils.ts | Adds Copilot/OpenClaw labels for home status presentation. |
| apps/web/src/components/ChatView.tsx | Switches picker callback to use setProviderAndModel in one store write. |
| apps/web/src/components/chat/providerStatusPresentation.ts | Adds Copilot provider label. |
| apps/web/src/components/chat/ProviderSetupCard.tsx | Adds Copilot install/auth/verify command hints. |
| apps/web/src/components/chat/ProviderModelPicker.tsx | Implements the new two-column provider/model popup and adds Copilot icon handling. |
| apps/web/src/components/chat/ProviderModelPicker.browser.tsx | Updates browser tests to reflect two-pane behavior and switching. |
| apps/web/src/components/chat/composerProviderRegistry.tsx | Adds Copilot provider registry entry + model options dispatch. |
| apps/web/src/appSettings.ts | Adds Copilot settings keys, defaults, custom model config, and provider start options mapping. |
| apps/server/src/sme/Layers/SmeChatServiceLive.ts | Marks Copilot unsupported for SME chat and tightens provider-runtime routing. |
| apps/server/src/sme/authValidation.ts | Restricts Copilot SME auth methods to auto. |
| apps/server/src/serverLayers.ts | Wires Copilot adapter layer into server provider layer composition. |
| apps/server/src/provider/Services/CopilotAdapter.ts | Introduces Copilot adapter service contract. |
| apps/server/src/provider/Layers/ProviderHealth.ts | Adds a Copilot CLI health probe using @github/copilot-sdk. |
| apps/server/src/provider/Layers/ProviderAdapterRegistry.ts | Registers Copilot adapter in default registry list. |
| apps/server/src/provider/Layers/ProviderAdapterRegistry.test.ts | Updates registry tests to include Copilot. |
| apps/server/src/provider/Layers/CopilotAdapter.ts | Adds full Copilot adapter implementation (session, turn, events, approvals, user input). |
| apps/server/src/doctor.ts | Includes Copilot in doctor health checks and setup guidance. |
| apps/server/package.json | Adds @github/copilot-sdk dependency to server package. |
Comments suppressed due to low confidence (1)
apps/server/src/serverLayers.ts:26
- The PR description focuses on the web provider/model picker UI, but this PR also introduces a full new server-side Copilot adapter layer and runtime health check integration. Please update the PR description/title to reflect this scope (or split into separate PRs) to make review/risk assessment clearer.
import { RuntimeReceiptBusLive } from "./orchestration/Layers/RuntimeReceiptBus";
import { ProviderUnsupportedError } from "./provider/Errors";
import { makeClaudeAdapterLive } from "./provider/Layers/ClaudeAdapter";
import { makeCopilotAdapterLive } from "./provider/Layers/CopilotAdapter";
import { makeCodexAdapterLive } from "./provider/Layers/CodexAdapter";
import { makeOpenClawAdapterLive } from "./provider/Layers/OpenClawAdapter";
import { ProviderAdapterRegistryLive } from "./provider/Layers/ProviderAdapterRegistry";
import { makeProviderServiceLive } from "./provider/Layers/ProviderService";
import { ProviderSessionDirectoryLive } from "./provider/Layers/ProviderSessionDirectory";
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
Resolved and included in another branch 8ce9bc1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
Screenshot